chore: update code generation and styleguide instructions concerning use of auto keyword - #16346
Open
scotthart wants to merge 2 commits into
Open
chore: update code generation and styleguide instructions concerning use of auto keyword#16346scotthart wants to merge 2 commits into
scotthart wants to merge 2 commits into
Conversation
…use of auto keyword
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new section to .agents/AGENTS.md outlining guidelines for type deduction and the use of auto in C++ based on Abseil Tip #232. The reviewer suggested clarifying that bare auto deduces by value to prevent accidental copies when a reference or pointer is intended.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16346 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 2227 2227
Lines 209357 209357
=======================================
+ Hits 193101 193107 +6
+ Misses 16256 16250 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we were writing all the code by hand, we have been lax in following the Google Style Guide directives for the use of
auto. This made writing code a little easier at the cost of readability.Now that more code is being generated, it's less onerous to use more explicit types and even more important to maximize human readability of code.